Conversation
mekarpeles
commented
May 19, 2025
mekarpeles
commented
- docker/configure.sh builds lenny.env (untracked); no more template or testing
- TESTING set by passing env variable to docker or setting in lenny.env
- sets up s3 buckets
- configures s3 and db from lenny/models
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the configuration by removing the template environment file and consolidating configuration logic in a generated lenny.env file and updated scripts. Additionally, it refactors database and S3 configurations, updates the FastAPI app initialization, and adjusts Docker, compose, and README files for improved clarity and maintainability.
- Removed lenny_TEMPLATE.env in favor of generating lenny.env via docker/configure.sh
- Refactored database and S3 configurations in models and configs
- Updated Dockerfile, compose.yaml, and README.md to reflect the streamlined configuration
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lenny_TEMPLATE.env | Removed the template environment file (deprecated). |
| lenny/models/lending.py | Introduced new SQLAlchemy models for the lending system. |
| lenny/models/init.py | Updated session handling, added S3 bucket initialization, and adjusted all. |
| lenny/configs/init.py | Refactored DB and S3 configurations. |
| lenny/app.py | Enhanced app initialization with metadata and versioning. |
| docker/nginx/nginx.conf | Added a client max body size directive. |
| docker/configure.sh | New script to generate lenny.env and set defaults securely. |
| docker/Dockerfile | Revised package installation and exposed additional ports. |
| compose.yaml | Updated environment variables and volume mappings. |
| README.md | Modified installation and rebuild instructions. |
| .env.test | Removed test environment configuration in alignment with new defaults. |
mekarpeles
force-pushed
the
cleanup-config
branch
from
afaef5d to
0e2e609
Compare
mekarpeles
force-pushed
the
cleanup-config
branch
from
0e2e609 to
a208644
Compare
|
@ronibhakta1 would you like to provide a review? :) |
would love to reivew it. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Nice job @ronibhakta1, thank you -- added you as a co-author on the commits before merging We'll need to make sure our forks are synched with this repo before submitting our next PR |
